Ticket #200 (reopened task)

Opened 3 years ago

Last modified 3 months ago

api inconsistency re StateVariable in ServiceServer

Reported by: dev Assigned to: dev
Priority: trivial Milestone: 1.0
Component: Core Version:
Keywords: Cc:

Description

There is an api inconsistency in ServiceServer? regarding getting a StateVariable? and setting its value:

  • get_variable(self, variable_name, instance=0)
  • set_variable(self, instance, variable_name, value, default=False)

Change History

19.10.2009 17:19:52 changed by dev

  • status changed from new to assigned.

19.10.2009 17:20:22 changed by dev

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [1457]) fix wrong argument order - annoying, time to fix #200

19.10.2009 17:26:31 changed by dev

  • status changed from closed to reopened.
  • resolution deleted.

ha - unintentionally closed by wrong keyword

27.11.2009 09:27:03 changed by jmsizun

  • priority changed from major to trivial.

What would be the proper way?

  • get_variable(self, instance, variable_name)
  • set_variable(self, instance, variable_name, value, default=False)

OR

  • get_variable(self, variable_name, instance=0)
  • set_variable(self, variable_name, value, instance=0, default=False)